Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the ClimateGuard RadSens Geiger-Muller tube #5425

Merged
merged 10 commits into from
Nov 24, 2024
Merged

Support for the ClimateGuard RadSens Geiger-Muller tube #5425

merged 10 commits into from
Nov 24, 2024
+154 −10

Conversation

jake-b
Copy link
Contributor

@jake-b jake-b commented Nov 22, 2024

This PR is to support the ClimateGuard RadSense dosimeter.
A fun and educational sensor for Meshtastic; not for safety critical applications.

This is an I2C device which integrates nicely into the firmware along side other sensors.

This pairs with a pull [request to add a field and enumeration to the protobufs](Support for the ClimateGuard RadSens Geiger-Muller tube #626)

Changes:

  • `detect/ScanI2CTwoWire.cpp - adds the ability to find the device on the I2C bus during scan
  • modules/Telemetry/Sensor/CGRadSensSensor.* - adds support for reading the sensor
  • modules/Telemetry/EnvironmentTelemetry.cpp- updates to handle the new sensor, also updates the display code to not show temperature/humidity unless it is present in the measurement.

Thanks for your consideration of this, my first contribution to Meshtastic

caveman99
caveman99 requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, for some minor changes see inline comments.

src/mesh/generated/meshtastic/telemetry.pb.h Outdated Show resolved Hide resolved
protobufs Outdated Show resolved Hide resolved
src/modules/Telemetry/EnvironmentTelemetry.cpp Outdated Show resolved Hide resolved
@GUVWAF
Copy link
Member

GUVWAF commented Nov 23, 2024

Since this is a rather specific sensor and we're very close to the flash limit on nRF52 devices, I think it would be good to introduce a macro like MESHTASTIC_EXCLUDE_NICHE_SENSORS in order to exclude this and maybe some other sensors for that platform.

@caveman99
Copy link
Member

Since this is a rather specific sensor and we're very close to the flash limit on nRF52 devices, I think it would be good to introduce a macro like MESHTASTIC_EXCLUDE_NICHE_SENSORS in order to exclude this and maybe some other sensors for that platform.

Do you care to have it inside of this, or can i merge it and create another PR? i wanted to introduce exclude_ethernet too...

@GUVWAF
Copy link
Member

GUVWAF commented Nov 24, 2024

Do you care to have it inside of this, or can i merge it and create another PR? i wanted to introduce exclude_ethernet too...

I'm fine with merging this as is. PR looks good otherwise.

@caveman99 caveman99 merged commit 932966b into meshtastic:master Nov 24, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GUVWAF GUVWAF GUVWAF approved these changes

@caveman99 caveman99 caveman99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jake-b @GUVWAF @caveman99